From 256621e2a595b87bd94e594a37dcfb76bbf85d66 Mon Sep 17 00:00:00 2001
From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Wed, 3 Mar 2021 13:35:49 -0700
Subject: [PATCH] use object tree to cleanup UpgradeCheck,
 UpgradeCheck::manager_ and (#692)

UpgradeCheck::replyId.
---
 gui/main.cc       |  4 +---
 gui/mainwindow.cc | 12 +-----------
 gui/mainwindow.h  |  1 -
 gui/upgrade.cc    | 18 +++---------------
 gui/upgrade.h     | 14 +++++---------
 5 files changed, 10 insertions(+), 39 deletions(-)

diff --git a/gui/main.cc b/gui/main.cc
index 87a4a3fdc..cb204d159 100644
--- a/gui/main.cc
+++ b/gui/main.cc
@@ -44,7 +44,5 @@ int main(int argc, char** argv)
 
   MainWindow mainWindow(nullptr);
   mainWindow.show();
-  QApplication::exec();
-
-  return 0;
+  return QApplication::exec();
 }
diff --git a/gui/mainwindow.cc b/gui/mainwindow.cc
index cb85045d5..1c5af45af 100644
--- a/gui/mainwindow.cc
+++ b/gui/mainwindow.cc
@@ -232,7 +232,7 @@ MainWindow::MainWindow(QWidget* parent): QMainWindow(parent)
   //--- Restore from registry
   restoreSettings();
 
-  upgrade = new UpgradeCheck(parent, formatList_, babelData_);
+  upgrade = new UpgradeCheck(this, formatList_, babelData_);
   if (babelData_.startupVersionCheck_) {
     upgrade->checkForUpgrade(babelVersion_, babelData_.upgradeCheckTime_,
                              allowBetaUpgrades());
@@ -246,14 +246,6 @@ MainWindow::MainWindow(QWidget* parent): QMainWindow(parent)
   }
 }
 
-//------------------------------------------------------------------------
-MainWindow::~MainWindow()
-{
-
-  delete upgrade;
-
-}
-
 //------------------------------------------------------------------------
 // Called every time, when a menu entry of the language menu is called
 void MainWindow::slotLanguageChanged(QAction* action)
@@ -1048,8 +1040,6 @@ void MainWindow::closeActionX()
     babelData_.donateSplashed_ = now;
   }
   saveSettings();
-  delete upgrade;
-  upgrade = nullptr;
   qApp->exit(0);
 }
 
diff --git a/gui/mainwindow.h b/gui/mainwindow.h
index 51a0dd728..c3539a502 100644
--- a/gui/mainwindow.h
+++ b/gui/mainwindow.h
@@ -53,7 +53,6 @@ class MainWindow: public QMainWindow
 
 public:
   MainWindow(QWidget* parent);
-  ~MainWindow();
 
 
 private:
diff --git a/gui/upgrade.cc b/gui/upgrade.cc
index ecb796ce7..5674a08ac 100644
--- a/gui/upgrade.cc
+++ b/gui/upgrade.cc
@@ -61,18 +61,6 @@ UpgradeCheck::UpgradeCheck(QWidget* parent, QList<Format>& formatList,
 {
 }
 
-UpgradeCheck::~UpgradeCheck()
-{
-  if (replyId_ != nullptr) {
-    replyId_->abort();
-    replyId_ = nullptr;
-  }
-  if (manager_ != nullptr) {
-    delete manager_;
-    manager_ = nullptr;
-  }
-}
-
 bool UpgradeCheck::isTestMode()
 {
   return testing;
@@ -96,11 +84,11 @@ QString UpgradeCheck::getCpuArchitecture()
 }
 
 UpgradeCheck::updateStatus UpgradeCheck::checkForUpgrade(
-  const QString& currentVersionIn,
+  const QString& currentVersion,
   const QDateTime& lastCheckTime,
   bool allowBeta)
 {
-  currentVersion_ = currentVersionIn;
+  currentVersion_ = currentVersion;
 
   QDateTime soonestCheckTime = lastCheckTime.addDays(1);
   if (!testing && QDateTime::currentDateTime() < soonestCheckTime) {
@@ -108,7 +96,7 @@ UpgradeCheck::updateStatus UpgradeCheck::checkForUpgrade(
     return updateUnknown;
   }
 
-  manager_ = new QNetworkAccessManager;
+  manager_ = new QNetworkAccessManager(this);
 
   connect(manager_, &QNetworkAccessManager::finished,
           this, &UpgradeCheck::httpRequestFinished);
diff --git a/gui/upgrade.h b/gui/upgrade.h
index 64f07f76a..e9984a2d4 100644
--- a/gui/upgrade.h
+++ b/gui/upgrade.h
@@ -36,7 +36,6 @@ class UpgradeCheck : public QObject
   Q_OBJECT
 public:
   UpgradeCheck(QWidget* parent, QList<Format>& formatList, BabelData& bd);
-  ~UpgradeCheck();
 
   enum updateStatus {
     updateUnknown,
@@ -44,15 +43,13 @@ public:
     updateNeeded,
   };
 
-  UpgradeCheck::updateStatus checkForUpgrade(const QString& babelVersion,
+  UpgradeCheck::updateStatus checkForUpgrade(const QString& currentVersion,
       const QDateTime& lastCheckTime,
       bool allowBeta);
   QDateTime getUpgradeWarningTime();
   UpgradeCheck::updateStatus getStatus();
   static bool isTestMode();
 
-protected:
-
 private:
   QString currentVersion_;
   QNetworkAccessManager* manager_;
@@ -64,15 +61,14 @@ private:
   updateStatus updateStatus_;
   BabelData& babelData_;
 
-  QString getOsName();
-  QString getOsVersion();
-  QString getCpuArchitecture();
-  bool suggestUpgrade(const QString& from, const QString& to);
+  static QString getOsName();
+  static QString getOsVersion();
+  static QString getCpuArchitecture();
+  static bool suggestUpgrade(const QString& from, const QString& to);
 
 private slots:
   void httpRequestFinished(QNetworkReply* reply);
 
-
 };
 
 #endif // UPGRADE_H
-- 
2.30.2